Update cppcheck config to pass cleanly #3829
Open
+21
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cppcheck runs just fine for me without these, though it's possible a different version of cppcheck would still require them.
* -I is needed to find crmcommon_private.h for checking things in lib/common. * --include is needed because otherwise it can't figure out where the definition of QB_XS comes from. It seems like this shouldn't be necessary, but I haven't been able to figure out another way.
cppcheck doesn't understand the use of PCMK__VALGRIND_EXEC here, I think because it's multiple strings concatenated together, and then wedged inside a ternary operator. In general I don't like rearranging code just to please static analysis, but I don't really like how this code was arranged in the first place. I think it's a little easier to follow duplicated like this.
With these, cppcheck passes cleanly.
|
Retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@waltdisgrace Here's another simple one. My only concern here is that different versions of cppcheck may still require the older suppression messages. However, I don't think we mention anywhere what version of static analysis tools the pacemaker code is expected to pass with. Maybe we should specify that somewhere.